-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HTML response handling for target allocator #3652
Open
CharlieTLe
wants to merge
3
commits into
open-telemetry:main
Choose a base branch
from
CharlieTLe:otel-targetallocator-html
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add HTML response handling for target allocator #3652
CharlieTLe
wants to merge
3
commits into
open-telemetry:main
from
CharlieTLe:otel-targetallocator-html
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9c6e2a
to
d6cb377
Compare
4fc7fa4
to
76cf475
Compare
atoulme
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok to me.
Signed-off-by: Charlie Le <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
e7ca1d8
to
b4f43e2
Compare
Signed-off-by: Charlie Le <[email protected]>
iblancasa
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for HTML output in the target allocator.
Link to tracking Issue(s):
Testing:
Configured unit tests with golden files to test that HTML renders the correct response.
To start the test, run
Setup a TA
Port-forward to the TA pod.
Once port-forwarded, go to http://localhost:8080.
Screenshots:
Home
Scrape Configs
Jobs
Targets
Collector
Job
Target